fix(prd-7): M5 code quality review — remove dead re-exports, verify type safety

- Removed unused re-exports (CommentUpdateInput, ExecutionDetails,
  ensureProperlyEncodedUrl) from forgejo/comment-logic.ts
- Verified no `any` type escapes in Forgejo-specific code
- Confirmed naming conventions consistent with upstream
- No dead code, unused imports, or unreachable branches
- All complex decisions documented with comments
- Typecheck, format, and 834 tests pass clean

Progress: 83% complete — M6 (documentation accuracy) remaining

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Vlad MocanuandClaude Opus 4.6 committed 2026-02-26 12:57:25 +02:00
1 parent bbfd630fc5
commit 741f12afaf
2 files changed
+1 -8

No files matched your search

+1 -1
View File
@@ -92,7 +92,7 @@ Perform a thorough, documented code review of all Forgejo-related changes. The r
- Verify mocks accurately represent Forgejo API responses - Verify mocks accurately represent Forgejo API responses
- **Deliverable**: Test coverage improved, gaps documented - **Deliverable**: Test coverage improved, gaps documented
- [ ] **M5: Code quality & maintainability review** - [x] **M5: Code quality & maintainability review**
- TypeScript strictness: are types accurate or using `any` / type assertions? - TypeScript strictness: are types accurate or using `any` / type assertions?
- Naming conventions: consistent with the rest of the codebase? - Naming conventions: consistent with the rest of the codebase?
-7
View File
@@ -12,13 +12,6 @@
import { getServerUrl } from "../github/api/config"; import { getServerUrl } from "../github/api/config";
// Re-export types so consumers don't need to import from two places
export type {
CommentUpdateInput,
ExecutionDetails,
} from "../github/operations/comment-logic";
export { ensureProperlyEncodedUrl } from "../github/operations/comment-logic";
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Run index helper // Run index helper
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------