From 741f12afaf6326ffce2a9f1742f45fa409fed04c Mon Sep 17 00:00:00 2001 From: Vlad Mocanu Date: Thu, 26 Feb 2026 12:57:25 +0200 Subject: [PATCH] =?UTF-8?q?fix(prd-7):=20M5=20code=20quality=20review=20?= =?UTF-8?q?=E2=80=94=20remove=20dead=20re-exports,=20verify=20type=20safet?= =?UTF-8?q?y?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed unused re-exports (CommentUpdateInput, ExecutionDetails, ensureProperlyEncodedUrl) from forgejo/comment-logic.ts - Verified no `any` type escapes in Forgejo-specific code - Confirmed naming conventions consistent with upstream - No dead code, unused imports, or unreachable branches - All complex decisions documented with comments - Typecheck, format, and 834 tests pass clean Progress: 83% complete — M6 (documentation accuracy) remaining Co-Authored-By: Claude Opus 4.6 --- prds/7-senior-review-forgejo.md | 2 +- src/forgejo/comment-logic.ts | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/prds/7-senior-review-forgejo.md b/prds/7-senior-review-forgejo.md index 73128f8..dd61430 100644 --- a/prds/7-senior-review-forgejo.md +++ b/prds/7-senior-review-forgejo.md @@ -92,7 +92,7 @@ Perform a thorough, documented code review of all Forgejo-related changes. The r - Verify mocks accurately represent Forgejo API responses - **Deliverable**: Test coverage improved, gaps documented -- [ ] **M5: Code quality & maintainability review** +- [x] **M5: Code quality & maintainability review** - TypeScript strictness: are types accurate or using `any` / type assertions? - Naming conventions: consistent with the rest of the codebase? diff --git a/src/forgejo/comment-logic.ts b/src/forgejo/comment-logic.ts index 1846dfd..aa697f6 100644 --- a/src/forgejo/comment-logic.ts +++ b/src/forgejo/comment-logic.ts @@ -12,13 +12,6 @@ import { getServerUrl } from "../github/api/config"; -// Re-export types so consumers don't need to import from two places -export type { - CommentUpdateInput, - ExecutionDetails, -} from "../github/operations/comment-logic"; -export { ensureProperlyEncodedUrl } from "../github/operations/comment-logic"; - // --------------------------------------------------------------------------- // Run index helper // ---------------------------------------------------------------------------