Vlad Mocanu and Claude Opus 4.6
ac58fb6c14
fix(prd-7): M1 architecture review — consolidate duplication, fix bugs, memoize detection
...
- F1: Consolidated updateForgejoCommentBody into unified updateCommentBody (~150 lines removed)
- F2: Fixed wrong run identifier in update-with-branch.ts (context.runId → getForgejoRunIndex())
- F3: Memoized detectPlatform() with _resetPlatformCache() for tests
- F4: Added getServerUrl() runtime helper to resolve constant-vs-function inconsistency
- F5: Fixed sticky comment bot matching on Forgejo via context.inputs.botName
- F6: Documented GHES heuristic misidentification in docs/forgejo.md
- Updated PRD M1 checkbox to complete
Progress: 17% complete — M1 done, M2 (error handling review) next
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-26 12:09:02 +02:00
Vlad Mocanu and Claude Opus 4.6
23f15aecb9
fix: use GITHUB_RUN_NUMBER for Forgejo job URLs and pin Bun version in CI
...
Forgejo uses the per-repo sequential run index (GITHUB_RUN_NUMBER) in
action URLs, not the internal DB run ID (GITHUB_RUN_ID). This caused
"View job" links to return 404. Fixed in all 4 URL construction sites:
create-initial comment, update-comment-link, and both prompt generators.
Also pins Bun to 1.2.21 in CI — Bun 1.3.9 broke spyOn(fs, ...) which
failed 18 upstream image-downloader tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-25 21:07:40 +02:00
Vlad Mocanu and Claude Opus 4.6
0802ac18eb
feat(prd-1): implement M5 - Forgejo comment URL formatting
...
- Create src/forgejo/comment-logic.ts with Forgejo-specific URL builders:
- Unicode spinner (replaces GitHub CDN image)
- PR compare URL with expand=1 (no quick_pull=1)
- Dynamic extractOwnerRepoFromUrl() fixing hardcoded github.com regex
- updateForgejoCommentBody() with cross-platform URL extraction
- 41 tests covering all URL patterns, spinner, and the critical regex fix
- No upstream files modified (lean adapter approach)
Progress: 56% complete (5/9) - next: M6 (MCP server platform routing)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-25 17:48:16 +02:00
