docs(prd-6): mark M7 complete — documentation updated with full E2E results
- Updated docs/forgejo.md E2E table with all 5 validated trigger scenarios - Added "Webhook & Event Differences" section (12-row comparison table) - Added 4 new Known Limitations and 5 new Troubleshooting entries - Removed "Not Yet E2E Tested" section — all triggers validated - PRD #6 is 100% complete (all 7 milestones done) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
1 parent
ccac5aff1e
commit
4a30b9819e
2 files changed
+69
-21
No files matched your search
@@ -105,12 +105,14 @@ Systematically exercise each untested scenario on the live Forgejo instance (git
|
||||
1. `f08b1b4`: Prompt template in `src/create-prompt/index.ts` (lines 604, 794) hardcoded `quick_pull=1` (GitHub-specific) in the "Create a PR" URL. On Forgejo, this param is ignored so the compare page doesn't auto-expand the PR creation form. Forgejo uses `expand=1`. Fix: made prompt template platform-aware via `detectPlatform()`. Note: `updateForgejoCommentBody()` extracts PR URLs from comment content (`prLinkFromContent`) with priority over the URL from `update-comment-link.ts`, so the prompt template is the correct fix location.
|
||||
- **Key learning**: The PR compare URL appears in two places — the prompt template (used by Claude to write the URL into comment body) and `update-comment-link.ts` (post-execution update). Because `updateForgejoCommentBody()` prioritizes URLs found in existing content, both must use the correct platform-specific query parameter. Fix validated after merge to `main` (workflow runs from default branch for `issue_comment` events).
|
||||
|
||||
- [ ] **M7: Update documentation with E2E results**
|
||||
- Update `docs/forgejo.md` E2E status table with results for all 5 scenarios
|
||||
- Move tested items from "Not Yet E2E Tested" to the validated table
|
||||
- Document any Forgejo-specific quirks or limitations discovered
|
||||
- Add troubleshooting entries for any issues encountered
|
||||
- **Validation**: `docs/forgejo.md` accurately reflects the current E2E validation status
|
||||
- [x] **M7: Update documentation with E2E results**
|
||||
- Updated `docs/forgejo.md` E2E status table with all 5 validated trigger scenarios ✓
|
||||
- Removed "Not Yet E2E Tested" section entirely — all items validated ✓
|
||||
- Added new "Webhook & Event Differences" section with 12-row comparison table documenting all Forgejo payload/event divergences ✓
|
||||
- Added 4 new Known Limitations entries (dead `pull_request_review` trigger, review comments as issue comments, unreliable workflow `if:`, assignees API) ✓
|
||||
- Added 5 new Troubleshooting entries (review reply tracking, `if:` skipping, `#` parse errors, duplicate label fires, `mock.module()` pollution) ✓
|
||||
- Expanded "Tag Mode Verified Capabilities" from 6 to 10 bullet points ✓
|
||||
- **Validation**: `docs/forgejo.md` accurately reflects the current E2E validation status ✓
|
||||
|
||||
## Dependencies
|
||||
|
||||
|
||||
Reference in new issue
Block a user